Messages in this thread | | | Date | Sun, 19 Aug 2018 20:34:03 +0800 | From | Wei Yang <> | Subject | Re: [PATCH v1 5/5] mm/memory_hotplug: print only with DEBUG_VM in online/offline_pages() |
| |
On Fri, Aug 17, 2018 at 10:18:53AM +0200, Oscar Salvador wrote: >> failed_addition: >> +#ifdef CONFIG_DEBUG_VM >> pr_debug("online_pages [mem %#010llx-%#010llx] failed\n", >> (unsigned long long) pfn << PAGE_SHIFT, >> (((unsigned long long) pfn + nr_pages) << PAGE_SHIFT) - 1); >> +#endif > >I have never been sure about this. >IMO, if I fail to online pages, I want to know I failed. >I think that pr_err would be better than pr_debug and without CONFIG_DEBUG_VM. > >But at least, if not, envolve it with a CONFIG_DEBUG_VM, but change pr_debug to pr_info. >
I don't have a clear rule about these debug macro neither.
While when you look at the page related logs in calculate_node_totalpages(), it is KERNEL_DEBUG level and without any config macro.
Maybe we should leave them at the same state?
>> +#ifdef CONFIG_DEBUG_VM >> pr_debug("memory offlining [mem %#010llx-%#010llx] failed\n", >> (unsigned long long) start_pfn << PAGE_SHIFT, >> ((unsigned long long) end_pfn << PAGE_SHIFT) - 1); >> +#endif > >Same goes here. > >Thanks >-- >Oscar Salvador >SUSE L3
-- Wei Yang Help you, Help me
| |