lkml.org 
[lkml]   [2018]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] ethernet: lpc_eth: Use NULL to compare with pointer-typed value rather than 0
    On 2018/8/17 23:29, Vladimir Zapolskiy wrote:
    > Hi zhong jiang,
    >
    > On 08/17/2018 04:18 PM, zhong jiang wrote:
    >> We should use NULL to compare with pointer-typed value rather than 0.
    >> The issue is detected with the help of Coccinelle.
    >> ---
    >> drivers/net/ethernet/nxp/lpc_eth.c | 2 +-
    >> 1 file changed, 1 insertion(+), 1 deletion(-)
    >>
    >> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
    >> index 08381ef..04d9e62 100644
    >> --- a/drivers/net/ethernet/nxp/lpc_eth.c
    >> +++ b/drivers/net/ethernet/nxp/lpc_eth.c
    >> @@ -1350,7 +1350,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
    >> "IRAM not big enough for net buffers, using SDRAM instead.\n");
    >> }
    >>
    >> - if (pldat->dma_buff_base_v == 0) {
    >> + if (pldat->dma_buff_base_v == NULL) {
    > That's a valid finding, but please use a common 0 and NULL comparison in form of
    >
    > if (!pldat->dma_buff_base_v)
    >
    > To the change above please feel free to add my
    >
    > Acked-by: Vladimir Zapolskiy <vz@mleia.com>
    Thanks, Will do in v2
    >> ret = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
    >> if (ret)
    >> goto err_out_free_irq;
    >>
    >
    > .
    >


    \
     
     \ /
      Last update: 2018-08-18 08:00    [W:5.250 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site