Messages in this thread Patch in this message |  | | From | Rasmus Villemoes <> | Subject | [PATCH 5/7] linux/bitmap.h: relax comment on compile-time constant nbits | Date | Sat, 18 Aug 2018 15:16:21 +0200 |
| |
It's not clear what's so horrible about emitting a function call to handle a run-time sized bitmap. Moreover, gcc also emits a function call for a compile-time-constant-but-huge nbits, so the comment isn't even accurate.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- include/linux/bitmap.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h index e34c361f4a92..3f0cac3aedca 100644 --- a/include/linux/bitmap.h +++ b/include/linux/bitmap.h @@ -28,8 +28,8 @@ * The available bitmap operations and their rough meaning in the * case that the bitmap is a single unsigned long are thus: * - * Note that nbits should be always a compile time evaluable constant. - * Otherwise many inlines will generate horrible code. + * The generated code is more efficient when nbits is known at + * compile-time and at most BITS_PER_LONG. * * :: * -- 2.16.4
|  |