lkml.org 
[lkml]   [2018]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit
On Fri, Aug 17, 2018 at 2:07 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Aug 16, 2018 at 2:27 AM, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
>> This driver prints that "Unsupported machine..." message on every boot on
>> ThinkPad X1 Carbon laptops (and I assume a number of other systems), which
>> causes graphical boots to "glitch" a bit and is rather annoying ...
>>
>> Make it a pr_debug instead.
>
> Thanks for the patch. Unfortunately it doesn't apply.
> Please, check your mail clients and tools for formatting patch (it
> produced at the end spaces instead of tabs)

No need to resend _this_ time. I have pushed to my review and testing queue.

>>
>> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> ---
>>
>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>> index 8952173dd380..7f7192e8fdab 100644
>> --- a/drivers/platform/x86/acer-wmi.c
>> +++ b/drivers/platform/x86/acer-wmi.c
>> @@ -2216,7 +2216,7 @@ static int __init acer_wmi_init(void)
>> if (wmi_has_guid(AMW0_GUID1) &&
>> !dmi_check_system(amw0_whitelist) &&
>> quirks == &quirk_unknown) {
>> - pr_err("Unsupported machine has AMW0_GUID1, unable to load\n");
>> + pr_debug("Unsupported machine has AMW0_GUID1, unable to load\n");
>> return -ENODEV;
>> }
>>
>>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-08-17 13:10    [W:0.069 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site