lkml.org 
[lkml]   [2018]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] console: Add console=auto option
On (08/16/18 13:39), Prarit Bhargava wrote:
>
> + auto [X86] Enable ACPI SPCR console
^^^^
And arm64?


Any chance we can rename param to "spcr" or something more clear?
To explicitly state what exactly it's going to do. `auto' sounds
too general and doesn't tell me that much. I'm probably the only
here who can't see a connection between "auto" and "SPCR", but
still.

One more thing, as far as I can tell, acpi_parse_spcr() can fail
and return an error. arch_console_setup() hides all errors and
returns void. Should it return error code?

int arch_console_setup(void)
{
return acpi_parse_spcr(false, true);
}

Or maybe

void arch_console_setup(void)
{
if (acpi_parse_spcr(false, true))
pr_err(.........);
}

There can be other consoles in the system, logging an error is not
such a useless thing.

-ss

\
 
 \ /
  Last update: 2018-08-17 11:38    [W:0.224 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site