lkml.org 
[lkml]   [2018]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
    On Thu, Aug 16, 2018 at 9:56 PM Leo Li <sunpeng.li@amd.com> wrote:
    > On 2018-08-11 11:54 AM, Arnd Bergmann wrote:
    > >
    > > I tried implementing the two functions in KCOV: __sanitizer_cov_trace_cmpd
    > > and __sanitizer_cov_trace_cmpf, but that fails to build on architectures
    > > that do not support any floating-point functions, or would require making
    > > that code x86 specific as well. I also looked at what it would take to
    >
    > Hi Arnd,
    >
    > Is there a reason why we can't make __sanitizer_cov_trace_cmpd and
    > __sanitizer_cov_trace_cmpf X86 dependent?
    >
    > I sent out two patches to disable DCN1, but would prefer implementing
    > these two functions as opposed to disabling a component.

    I think it should be possible to implement them, perhaps not even hard
    to do it in an architecture independent way. I tried this at some point
    and couldn't figure it out, but I suppose it would fix the problem nicely.

    This would assume that the two functions can only ever be called
    from a context that already has access to the fpu, which I think is
    the case here.

    Arnd

    \
     
     \ /
      Last update: 2018-08-16 23:02    [W:8.711 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site