lkml.org 
[lkml]   [2018]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 3/8] backlight: qcom-wled: Add new properties for PMI8998
On 2018-08-07 10:53, Bjorn Andersson wrote:
> On Mon 09 Jul 03:22 PDT 2018, Kiran Gunda wrote:
>> diff --git
>> a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
>> b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> [..]
>> - qcom,num-strings
>> Usage: optional
>> Value type: <u32>
>> Definition: #; number of led strings attached;
>> - value from 1 to 3. default: 2
>> - This property is supported only for PM8941.
>> + value: For PM8941 from 1 to 3.
>> + For PMI8998 from 1 to 4.
> [..]
>> +- qcom,enabled-strings
>> + Usage: optional
>> + Value tyoe: <u32 array>
>> + Definition: Array of the WLED strings numbered from 0 to 3. Each
>> + string of leds are operated individually. Specify the
>> + list of strings used by the device. Any combination of
>> + led strings can be used.
> [..]
>>
>> Example:
>>
>> @@ -99,4 +146,5 @@ pm8941-wled@d800 {
>> qcom,switching-freq = <1600>;
>> qcom,ovp = <29>;
>> qcom,num-strings = <2>;
>> + qcom,enabled-strings = <0x00 0x01>;
>
> Nit. I would assume that specifying qcom,num-strings = <2> implies that
> the first 2 strings are used, so one would not also specify
> qcom,enabled-strings.
>
Thanks Bjorn for reviewing the series !

"qcom,enabled-strings" need be specified along with the
"qcom,num-strings".
Because the enabled-strings can be <0, 2> or <0, 3 > also. The driver
picks the string
configuration from the enabled-strings array and enable only those
current-sinks.

> (And you should use decimal for natural numbers)
>
I will modify it in next series.
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Regards,
> Bjorn
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

\
 
 \ /
  Last update: 2018-08-16 07:23    [W:0.155 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site