Messages in this thread | | | Subject | Re: [PATCH] x86/vdso: Fix vDSO build if a retpoline is emitted | From | David Woodhouse <> | Date | Thu, 16 Aug 2018 21:44:57 +0200 |
| |
On Thu, 2018-08-16 at 12:41 -0700, Andy Lutomirski wrote: > Currently, if the vDSO ends up containing an indirect branch or > call, GCC will emit the "external thunk" style of retpoline, and it > will fail to link. > > Fix it by building the vDSO with inline retpoline thunks. > > I haven't seen any reports of this triggering on an unpatched > kernel. > > Cc: Matt Rickard <matt@softrans.com.au> > Cc: Jason Vas Dias <jason.vas.dias@gmail.com> > Cc: David Woodhouse <dwmw2@infradead.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Andi Kleen <ak@linux.intel.com> > Fixes: commit 76b043848fd2 ("x86/retpoline: Add initial retpoline support") > Signed-off-by: Andy Lutomirski <luto@kernel.org>
Acked-by: David Woodhouse <dwmw@amazon.co.uk>
Thanks.[unhandled content-type:application/x-pkcs7-signature]
| |