Messages in this thread | | | From | "Ooi, Joyce" <> | Subject | RE: [PATCH] net: stmmac: Add SMC support for EMAC System Manager register | Date | Thu, 16 Aug 2018 03:39:36 +0000 |
| |
> -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Tuesday, August 14, 2018 12:48 AM > To: Ooi, Joyce <joyce.ooi@intel.com> > Cc: peppe.cavallaro@st.com; alexandre.torgue@st.com; > joabreu@synopsys.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; > Ong, Hean Loong <hean.loong.ong@intel.com>; Vandervennet, Yves > <yves.vandervennet@intel.com> > Subject: Re: [PATCH] net: stmmac: Add SMC support for EMAC System Manager > register > > From: "Ooi, Joyce" <joyce.ooi@intel.com> > Date: Sun, 12 Aug 2018 23:41:34 -0700 > > > As there is restriction to access to EMAC System Manager registers in > > the kernel for Intel Stratix10, the use of SMC calls are required and > > added in dwmac-socfpga driver. > > > > Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com> > > --- > > This patch is dependent on https://lkml.org/lkml/2018/7/26/624 > > I guess I cannot apply this to my networking tree then. > > I would suggest that you make a helper in a header file which dos the special > SMC EMAC accesses, or alternatively the regular regmap access, based upon the > CPP ifdef. Could you please explain what you mean by 'a helper in a header file'?
Thanks. > > That way you won't have to put all of those CPP tests in the foo.c code. > > Thanks.
| |