Messages in this thread | | | Subject | Re: [PATCH 1/2] phy:phy-brcm-us: Use PTR_ERR_OR_ZERO to replace the open code | From | Florian Fainelli <> | Date | Wed, 15 Aug 2018 16:23:49 -0700 |
| |
On 08/13/2018 04:24 AM, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement.
Subject should be:
phy: phy-brcm-usb: Use PTR_ERR_OR_ZERO to replace open coded version
Thank you
> > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > drivers/phy/broadcom/phy-brcm-usb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c > index d1dab36..f59b1dc 100644 > --- a/drivers/phy/broadcom/phy-brcm-usb.c > +++ b/drivers/phy/broadcom/phy-brcm-usb.c > @@ -372,10 +372,8 @@ static int brcm_usb_phy_probe(struct platform_device *pdev) > clk_disable(priv->usb_30_clk); > > phy_provider = devm_of_phy_provider_register(dev, brcm_usb_phy_xlate); > - if (IS_ERR(phy_provider)) > - return PTR_ERR(phy_provider); > > - return 0; > + return PTR_ERR_OR_ZERO(phy_provider); > } > > #ifdef CONFIG_PM_SLEEP >
-- Florian
| |