Messages in this thread | | | Subject | Re: [PATCH] kdb: kdb_support: mark expected switch fall-throughs | From | Daniel Thompson <> | Date | Wed, 15 Aug 2018 15:34:53 +0100 |
| |
On 05/08/18 03:48, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case, I replaced the code comments with > a proper "fall through" annotation, which is what GCC is expecting > to find. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> --- > kernel/debug/kdb/kdb_support.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c > index 990b3cc..89ac604 100644 > --- a/kernel/debug/kdb/kdb_support.c > +++ b/kernel/debug/kdb/kdb_support.c > @@ -432,7 +432,7 @@ int kdb_getphysword(unsigned long *word, unsigned long addr, size_t size) > *word = w8; > break; > } > - /* drop through */ > + /* fall through */ > default: > diag = KDB_BADWIDTH; > kdb_printf("kdb_getphysword: bad width %ld\n", (long) size); > @@ -481,7 +481,7 @@ int kdb_getword(unsigned long *word, unsigned long addr, size_t size) > *word = w8; > break; > } > - /* drop through */ > + /* fall through */ > default: > diag = KDB_BADWIDTH; > kdb_printf("kdb_getword: bad width %ld\n", (long) size); > @@ -525,7 +525,7 @@ int kdb_putword(unsigned long addr, unsigned long word, size_t size) > diag = kdb_putarea(addr, w8); > break; > } > - /* drop through */ > + /* fall through */ > default: > diag = KDB_BADWIDTH; > kdb_printf("kdb_putword: bad width %ld\n", (long) size); >
| |