lkml.org 
[lkml]   [2018]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 17/79] cpu/hotplug: Make bringup/teardown of smp threads symmetric
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Thomas Gleixner <tglx@linutronix.de>

    The asymmetry caused a warning to trigger if the bootup was stopped in state
    CPUHP_AP_ONLINE_IDLE. The warning no longer triggers as kthread_park() can
    now be invoked on already or still parked threads. But there is still no
    reason to have this be asymmetric.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Acked-by: Ingo Molnar <mingo@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    kernel/cpu.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/kernel/cpu.c
    +++ b/kernel/cpu.c
    @@ -754,7 +754,6 @@ static int takedown_cpu(unsigned int cpu

    /* Park the smpboot threads */
    kthread_park(per_cpu_ptr(&cpuhp_state, cpu)->thread);
    - smpboot_park_threads(cpu);

    /*
    * Prevent irq alloc/free while the dying cpu reorganizes the
    @@ -1332,7 +1331,7 @@ static struct cpuhp_step cpuhp_hp_states
    [CPUHP_AP_SMPBOOT_THREADS] = {
    .name = "smpboot/threads:online",
    .startup.single = smpboot_unpark_threads,
    - .teardown.single = NULL,
    + .teardown.single = smpboot_park_threads,
    },
    [CPUHP_AP_IRQ_AFFINITY_ONLINE] = {
    .name = "irq/affinity:online",

    \
     
     \ /
      Last update: 2018-08-14 20:14    [W:2.652 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site