Messages in this thread |  | | Subject | Re: [PATCH 6/9] platform: goldfish: pipe: Fail compilation if structs are too large | From | Joe Perches <> | Date | Mon, 13 Aug 2018 21:41:06 -0700 |
| |
On Mon, 2018-08-13 at 20:47 -0700, Roman Kiryanov wrote: > Hi, > > thank you for reviewing my patches. I decided to put BUILD_BUG_ON > close to places where it is important that these structs fit into a > memory page to give some context.
And you make the reader figure out what type dev->buffers is unnecessarily when sizeof(struct goldfish_pipe_dev_buffers) is pretty obvious.
> Regards, > Roman.
cheers, Joe
|  |