lkml.org 
[lkml]   [2018]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 088/104] x86/KVM/VMX: Dont set l1tf_flush_l1d from vmx_handle_external_intr()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nicolai Stange <nstange@suse.de>

    commit 18b57ce2eb8c8b9a24174a89250cf5f57c76ecdc upstream

    For VMEXITs caused by external interrupts, vmx_handle_external_intr()
    indirectly calls into the interrupt handlers through the host's IDT.

    It follows that these interrupts get accounted for in the
    kvm_cpu_l1tf_flush_l1d per-cpu flag.

    The subsequently executed vmx_l1d_flush() will thus be aware that some
    interrupts have happened and conduct a L1d flush anyway.

    Setting l1tf_flush_l1d from vmx_handle_external_intr() isn't needed
    anymore. Drop it.

    Signed-off-by: Nicolai Stange <nstange@suse.de>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/x86/kvm/vmx.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/arch/x86/kvm/vmx.c
    +++ b/arch/x86/kvm/vmx.c
    @@ -9460,7 +9460,6 @@ static void vmx_handle_external_intr(str
    [ss]"i"(__KERNEL_DS),
    [cs]"i"(__KERNEL_CS)
    );
    - vcpu->arch.l1tf_flush_l1d = true;
    }
    }
    STACK_FRAME_NON_STANDARD(vmx_handle_external_intr);

    \
     
     \ /
      Last update: 2018-08-14 19:43    [W:4.183 / U:1.556 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site