Messages in this thread | | | Subject | Re: [PATCH v2 2/5] watchdog: hpwdt: Claim NMI from iLO | From | Guenter Roeck <> | Date | Tue, 14 Aug 2018 06:30:58 -0700 |
| |
On 08/08/2018 12:13 PM, Jerry Hoemann wrote: > The hwpdt driver is overloaded for handling both the iLO > watchdog and the explicit "Generate NMI to System" virutal > button. Hence NMI handler needs to claim NMI resulting > from the virutal button. > > Claim if iLO generated accommodating firmware that might > set wrong bit. > > Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/watchdog/hpwdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index fae9364..bb41714 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -162,7 +162,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs) > if (ilo5 && ulReason == NMI_UNKNOWN && !mynmi) > return NMI_DONE; > > - if (ilo5 && !pretimeout) > + if (ilo5 && !pretimeout && !mynmi) > return NMI_DONE; > > hpwdt_stop(); >
| |