[lkml]   [2018]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] l2tp: fix unused function warning
From: Arnd Bergmann <>
Date: Mon, 13 Aug 2018 23:43:05 +0200

> Removing one of the callers of pppol2tp_session_get_sock caused a harmless
> warning in some configurations:
> net/l2tp/l2tp_ppp.c:142:21: 'pppol2tp_session_get_sock' defined but not used [-Wunused-function]
> Rather than adding another #ifdef here, using a proper IS_ENABLED()
> check makes the code more readable and avoids those warnings while
> letting the compiler figure out for itself which code is needed.
> This adds one pointer for the unused show() callback in struct
> l2tp_session, but that seems harmless.
> Fixes: b0e29063dcb3 ("l2tp: remove pppol2tp_session_ioctl()")
> Signed-off-by: Arnd Bergmann <>


 \ /
  Last update: 2018-08-14 05:47    [W:0.032 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site