lkml.org 
[lkml]   [2018]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes
On Tue, Aug 14, 2018 at 11:30:51AM +0200, David Hildenbrand wrote:

>
> While it is correct in current code, I wonder if this sanity check
> should stay. I would completely agree if it would be a static function.

Hi David,

Well, unregister_mem_sect_under_nodes() __only__ gets called from remove_memory_section().
But remove_memory_section() only calls unregister_mem_sect_under_nodes() IFF mem_blk
is not NULL:

static int remove_memory_section
{
...
mem = find_memory_block(section);
if (!mem)
goto out_unlock;

unregister_mem_sect_under_nodes(mem, __section_nr(section));
...
}

So, to me keeping the check is redundant, as we already check for it before calling in.

Thanks
--
Oscar Salvador
SUSE L3

\
 
 \ /
  Last update: 2018-08-14 11:37    [W:0.122 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site