Messages in this thread | | | From | Kees Cook <> | Date | Mon, 13 Aug 2018 15:32:16 -0700 | Subject | Re: [PATCH] Support mksh as /bin/sh. |
| |
On Mon, Aug 13, 2018 at 3:14 AM, <arekm@maven.pl> wrote: > From: Arkadiusz Miśkiewicz <arekm@maven.pl> > > mksh needs space between ! and ( to work properly. Otherwise this > happens: > > + make oldconfig > scripts/kconfig/conf --oldconfig Kconfig > ./scripts/clang-version.sh[18]: COPYING: not found > printf: ‘__clang_major__’: expected a numeric value > printf: ‘__clang_minor__’: expected a numeric value > printf: ‘__clang_patchlevel__’: expected a numeric value > init/Kconfig:24:warning: 'CLANG_VERSION': number is invalid > > Signed-off-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> --- > scripts/clang-version.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/clang-version.sh b/scripts/clang-version.sh > index dbf0a31eb111..e65fbc3079d4 100755 > --- a/scripts/clang-version.sh > +++ b/scripts/clang-version.sh > @@ -12,7 +12,7 @@ > > compiler="$*" > > -if !( $compiler --version | grep -q clang) ; then > +if ! ( $compiler --version | grep -q clang) ; then > echo 0 > exit 1 > fi > -- > 2.18.0 >
-- Kees Cook Pixel Security
| |