Messages in this thread |  | | From | Arnd Bergmann <> | Date | Tue, 14 Aug 2018 00:05:59 +0200 | Subject | Re: [PATCH] cpumask: provide a dummy cpumask_next_wrap |
| |
On Tue, Aug 14, 2018 at 12:02 AM Caleb Raitto <caraitto@google.com> wrote: > > On Mon, Aug 13, 2018 at 2:55 PM Arnd Bergmann <arnd@arndb.de> wrote: > > > > The virtio_net driver has become the first one to call cpumask_next_wrap() > > even if CONFIG_SMP is disabled, leading to a build error: > > > > drivers/net/virtio_net.c: In function 'virtnet_set_affinity': > > drivers/net/virtio_net.c:1916:10: error: implicit declaration of function 'cpumask_next_wrap'; did you mean 'cpumask_next_and'? [-Werror=implicit-function-declaration] > > cpu = cpumask_next_wrap(cpu, cpu_online_mask, > > > > Add a stub function along the lines of cpumask_first(), cpumask_next() etc. > > I'm not entirely sure what should be returned in this case, but at > > least for virtio_net, anything should work. > > Sorry about the build break, I think this patch with a fix was already merged: > > cpumask: make cpumask_next_wrap available without smp > https://patchwork.ozlabs.org/patch/956670/
Ok, that's also a better fix than mine I think.
Thanks,
Arnd
|  |