Messages in this thread |  | | Date | Mon, 13 Aug 2018 15:58:50 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf tools: Fix check-headers.sh AND list path of execution |
| |
Em Mon, Aug 13, 2018 at 02:19:10PM +0300, Alexander Kapshuk escreveu: > On Mon, Aug 13, 2018 at 2:16 PM Jiri Olsa <jolsa@redhat.com> wrote: > > > > On Sat, Aug 11, 2018 at 11:39:15AM +0300, Alexander Kapshuk wrote: > > > The '||' path of execution in the 'test' block of the check_2() function > > > may also be taken if file2 does not exist, in which case the warning > > > message about the ABI headers being different would still be printed > > > where it should not be. See below. > > > > > > % file1=file1; file2=file2 > > > % cmd="echo diff $file1 $file2" > > > % test -f $file2 && > > > eval $cmd || echo "Warning: Kernel ABI header at 'tools/$file1' > > > differs from latest version at '$file2'" >&2 > > > Warning: Kernel ABI header at 'tools/file1' differs from latest > > > version at 'file2' > > > > > > The proposed patch converts the code following the '&&' operator into a > > > compound list to be executed in the current process environment only if > > > file2 does exist. Should the files being compared differ, a diff command > > > to compare the files concerned is printed on standard output. E.g. > > > > > > diff -u tools/arch/x86/lib/memcpy_64.S arch/x86/lib/memcpy_64.S > > > > > > Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com> > > > > I posted follow up patches based on this one > > as a reply on this patch > > > > for this one: > > > > Acked-by: Jiri Olsa <jolsa@kernel.org> > > > > thanks, > > jirka > > Noted. > Thanks.
Thanks, applied the three patches to acme/perf/core.
- Arnaldo
|  |