Messages in this thread |  | | From | Brian Norris <> | Date | Mon, 13 Aug 2018 10:14:44 -0700 | Subject | Re: [PATCH] ath10k: retrieve MAC address from firmware if provided |
| |
On Sat, Aug 11, 2018 at 11:26 AM Arend van Spriel <arend.vanspriel@broadcom.com> wrote: > > On 8/11/2018 1:39 AM, Brian Norris wrote: > > Devices may provide their own MAC address via system firmware (e.g., > > You got me confused by using just "firmware" in the subject.
Yeah...I started by writing this patch with device tree specifically (of_get_mac_address()), and then later found that there were generic "device" helpers for this, which can assist with other sorts of firmware nodes. It was easier to put a name on a device tree patch than on a "device" patch. I suppose "system firmware" might be a better description?
> > device tree), especially in the case where the device doesn't have a > > useful EEPROM on which to store its MAC address (e.g., for integrated > > Wifi). > > > > Use the generic device helper to retrieve the MAC address, and (if > > present) honor it above the MAC address advertised by the card. > > But this put me back on track ;-)
Let me know if you have a better way to clarify. I can resend with a slightly modified subject (s/firmware/system firmware/), or let Kalle do it, if that's the only thing to change.
Brian
|  |