lkml.org 
[lkml]   [2018]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 1/9] net: hns3: Add support for serdes loopback selftest
From
From: Salil Mehta <salil.mehta@huawei.com>
Date: Sun, 12 Aug 2018 10:47:30 +0100

> -#define HNS3_SELF_TEST_TPYE_NUM 1
> +#define HNS3_SELF_TEST_TPYE_NUM 2

Is this supposed to be the number of self test "types"? If so, this CPP
macro should be named "HNS3_SELF_TEST_TYPE_NUM".

> +
> + count ++;
^

Please remove that unnecessary space.

> + } while (++i < HCLGE_SERDES_RETRY_NUM &&
^^

Only need one space there, not two.


\
 
 \ /
  Last update: 2018-08-13 17:55    [W:0.072 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site