lkml.org 
[lkml]   [2018]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 6/8] staging: erofs: fix vle_decompressed_index_clusterofs
From
Date
Hi Dan,

On 2018/8/13 20:03, Dan Carpenter wrote:
>> -static inline unsigned
>> -vle_compressed_index_clusterofs(unsigned clustersize,
>> - struct z_erofs_vle_decompressed_index *di)
>> +static inline int
>> +vle_decompressed_index_clusterofs(unsigned int *clusterofs,
>
> Not related to your patch, but don't make functions inline. Leave it to
> the compiler to decide.

OK, thanks for your suggestion.

Thanks,
Gao Xiang

>
> regards,
> dan carpenter
>
>

\
 
 \ /
  Last update: 2018-08-13 15:02    [W:0.608 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site