Messages in this thread |  | | Date | Mon, 13 Aug 2018 15:25:54 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 3/8] staging: erofs: add error handling for xattr submodule |
| |
On Mon, Aug 13, 2018 at 08:17:27PM +0800, Gao Xiang wrote: > > /* we assume that ofs is aligned with 4 bytes */ > > it->ofs = EROFS_XATTR_ALIGN(it->ofs); > > return err; > >
This might be cleaner if we wrote:
return (err < 0) ? error : 0;
The callers all treate zero and one the same so there isn't any reason to propogate the 1 back.
regards, dan carpenter
|  |