lkml.org 
[lkml]   [2018]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Revert "f2fs: use printk_ratelimited for f2fs_msg"
From
Date
On Mon, 2018-08-13 at 14:28 +0800, Chao Yu wrote:
> Don't limit printing log, so that we will not miss any key messages.
>
> This reverts commit a36c106dffb616250117efb1cab271c19a8f94ff.
[]
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
[]
> @@ -209,7 +209,7 @@ void f2fs_msg(struct super_block *sb, const char *level, const char *fmt, ...)
> va_start(args, fmt);
> vaf.fmt = fmt;
> vaf.va = &args;
> - printk_ratelimited("%sF2FS-fs (%s): %pV\n", level, sb->s_id, &vaf);
> + printk("%sF2FS-fs (%s): %pV\n", level, sb->s_id, &vaf);
> va_end(args);
> }

If there was value in ratelimiting these messages at all,
perhaps there is value in using a specific ratelimit_state
other than

static DEFINE_RATELIMIT_STATE(_rs, \
DEFAULT_RATELIMIT_INTERVAL, \
DEFAULT_RATELIMIT_BURST); \



\
 
 \ /
  Last update: 2018-08-13 11:51    [W:1.241 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site