Messages in this thread | | | Subject | Re: [PATCH] Revert "f2fs: use printk_ratelimited for f2fs_msg" | From | Joe Perches <> | Date | Mon, 13 Aug 2018 02:50:47 -0700 |
| |
On Mon, 2018-08-13 at 14:28 +0800, Chao Yu wrote: > Don't limit printing log, so that we will not miss any key messages. > > This reverts commit a36c106dffb616250117efb1cab271c19a8f94ff. [] > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c [] > @@ -209,7 +209,7 @@ void f2fs_msg(struct super_block *sb, const char *level, const char *fmt, ...) > va_start(args, fmt); > vaf.fmt = fmt; > vaf.va = &args; > - printk_ratelimited("%sF2FS-fs (%s): %pV\n", level, sb->s_id, &vaf); > + printk("%sF2FS-fs (%s): %pV\n", level, sb->s_id, &vaf); > va_end(args); > }
If there was value in ratelimiting these messages at all, perhaps there is value in using a specific ratelimit_state other than
static DEFINE_RATELIMIT_STATE(_rs, \ DEFAULT_RATELIMIT_INTERVAL, \ DEFAULT_RATELIMIT_BURST); \
| |