lkml.org 
[lkml]   [2018]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next] liquidio: remove set but not used variable 'is25G'
Date
> -----Original Message-----
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On
> Behalf Of YueHaibing
> Sent: Monday, August 13, 2018 12:51 PM
> To: davem@davemloft.net; Chickles, Derek <Derek.Chickles@cavium.com>;
> Burla, Satananda <Satananda.Burla@cavium.com>; Manlunas, Felix
> <Felix.Manlunas@cavium.com>; Vatsavayi, Raghu
> <Raghu.Vatsavayi@cavium.com>
> Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; YueHaibing
> <yuehaibing@huawei.com>
> Subject: [PATCH net-next] liquidio: remove set but not used variable 'is25G'
>
> External Email
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function
> 'lio_set_link_ksettings':
> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c:392:6: warning:
> variable 'is25G' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> index 807ea2c..5ce604a 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> @@ -389,16 +389,13 @@ static int lio_set_link_ksettings(struct net_device
> *netdev,
> struct lio *lio = GET_LIO(netdev);
> struct oct_link_info *linfo;
> struct octeon_device *oct;
> - u32 is25G = 0;
>
> oct = lio->oct_dev;
>
> linfo = &lio->linfo;
>
> - if (oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID ||
> - oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID) {
> - is25G = 1;
> - } else {
> + if (!(oct->subsystem_id == OCTEON_CN2350_25GB_SUBSYS_ID ||
> + oct->subsystem_id == OCTEON_CN2360_25GB_SUBSYS_ID)) {
> return -EOPNOTSUPP;
> }

You can also remove braces which are not required for single line.

Thanks,
Shahed

\
 
 \ /
  Last update: 2018-08-13 11:09    [W:0.043 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site