Messages in this thread | | | Date | Sun, 12 Aug 2018 17:33:31 +0530 | From | Himanshu Jha <> | Subject | Re: [PATCH] staging: gasket: remove null ptr check before kfree |
| |
On Sun, Aug 12, 2018 at 12:28:37PM +0530, Sumit Kumar wrote: > Remove null ptr check before kfree because kfree is null ptr safe. > Issue found by checkpatch. > > Signed-off-by: Sumit Kumar <sumit686215@example.com>
Hmm. Victim of copy-paste I guess. No worries. Next time just use:
$ git commit -s
To understand what -s flag does, refer `man git commit`.
> ---
Now, this where you should have put versions just below the '---':
v2: - corrected email address.
And yes, the subject should be:
"Subject: [PATCH v2] staging: gasket: remove null ptr check before kfree"
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
Hope that helps!
-- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology
| |