Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 10 Aug 2018 17:39:17 +0300 | Subject | Re: [PATCH v2 14/29] net: simplify eth_platform_get_mac_address() |
| |
On Fri, Aug 10, 2018 at 11:05 AM, Bartosz Golaszewski <brgl@bgdev.pl> wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > We don't need to use pci_device_to_OF_node() - we can retrieve > dev->of_node directly even for pci devices. >
> struct device_node *dp; > > - if (dev_is_pci(dev)) > - dp = pci_device_to_OF_node(to_pci_dev(dev)); > - else > - dp = dev->of_node; > - > + dp = dev->of_node; > addr = NULL; > if (dp) > addr = of_get_mac_address(dp);
Looking more at this I could even propose to change all above by
addr = device_get_mac_address(dev, mac_addr, ETH_ALEN);
Thoughts?
-- With Best Regards, Andy Shevchenko
| |