lkml.org 
[lkml]   [2018]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC PATCH v2 04/12] mtd: rawnand: ams-delta: request data port GPIO resource
    On Tue, Aug 7, 2018 at 12:29 AM Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote:

    > Data port used by the driver is actually an OMAP MPUIO device, already
    > under control of gpio-omap driver. For that reason we used to not
    > request the memory region of the port as that would fail because the
    > region is already busy. Despite that, we are still accessing the port
    > by just ioremapping it and performing read/write operations. Moreover,
    > we are doing that without any proteciton from other users legally
    > manipulating the port pins over GPIO API.
    >
    > The plan is to convert the driver to access the port over functions
    > exposed by the gpio-omap driver. Before that happens, already prevent
    > from other users accessing the port pins by requesting an array of its
    > GPIO descriptors.
    >
    > Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>

    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2018-08-10 12:12    [W:4.099 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site