lkml.org 
[lkml]   [2018]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines
From
Date
On Wed, 2018-08-01 at 16:09 +0100, Julien Thierry wrote:
> On 01/08/18 04:07, Ricardo Neri wrote:
> > On Tue, Jul 24, 2018 at 12:07:04PM +0100, Julien Thierry wrote:
> > > + || WARN_ON(irq_settings_is_per_cpu_devid(desc))
> > > + || !irq_supports_nmi(desc))
> >
> > Shouldn't the logical operators in a multi-line statement go at the end of
> > the line?
>
> I couldn't find anything about this in the kernel coding style and
> checkpatch didn't complain.

coding-style is a set of suggestions not dicta.

Many of the tests in checkpatch are not written out in
coding-style.

checkpatch does emit a message when used with --strict here:

The checkpatch test is:

# check for && or || at the start of a line
if ($rawline =~ /^\+\s*(&&|\|\|)/) {
CHK("LOGICAL_CONTINUATIONS",
"Logical continuations should be on the previous line\n" . $hereprev);
}

This message is not always emitted because code outside of
net, drivers/net, and drivers/staging does not use --strict
by default.

\
 
 \ /
  Last update: 2018-08-01 17:34    [W:0.080 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site