lkml.org 
[lkml]   [2018]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] aio: implement IOCB_CMD_POLL
On Mon, Jul 30, 2018 at 09:15:43AM +0200, Christoph Hellwig wrote:

> + apt.error = -EINVAL; /* same as no support for IOCB_CMD_POLL */

> + mask = vfs_poll(req->file, &apt.pt) & req->events;
> + if (mask || apt.error) {
> + bool removed = false;
> +
> + /* we did not manage to set up a waitqueue, done */
> + if (unlikely(!req->head))
> + goto out_fput;

> +out_fput:
> + fput(req->file);
> + return apt.error;

Ugh... So anything that simply returns a constant value, without
even bothering to do poll_wait() (on the theory that no matter how
much you wait, nothing will change) is going to git -EINVAL?
What am I missing here?

\
 
 \ /
  Last update: 2018-08-02 01:55    [W:0.073 / U:3.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site