lkml.org 
[lkml]   [2018]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.17 204/336] media: em28xx: Fix DualHD broken second tuner
    Date
    4.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Brad Love <brad@nextdimension.cc>

    [ Upstream commit 01affb000e00cfa0a9e9954476ef50962eb8b168 ]

    The use of a hard coded i2c address breaks the creation of the
    second tuner in DualHD 01595 models. The issue is compounded
    by lack of any error message stating that a driver failed
    initialization. Use addr, which contains the correct address
    for each tuner.

    Fixes: ad32495b1513 ("media: em28xx-dvb: simplify DVB module probing logic")

    Signed-off-by: Brad Love <brad@nextdimension.cc>
    Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/usb/em28xx/em28xx-dvb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/usb/em28xx/em28xx-dvb.c
    +++ b/drivers/media/usb/em28xx/em28xx-dvb.c
    @@ -1392,7 +1392,7 @@ static int em28174_dvb_init_hauppauge_wi

    dvb->i2c_client_tuner = dvb_module_probe("si2157", NULL,
    adapter,
    - 0x60, &si2157_config);
    + addr, &si2157_config);
    if (!dvb->i2c_client_tuner) {
    dvb_module_release(dvb->i2c_client_demod);
    return -ENODEV;

    \
     
     \ /
      Last update: 2018-08-01 20:00    [W:4.104 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site