Messages in this thread | | | From | Kees Cook <> | Date | Mon, 9 Jul 2018 08:56:50 -0700 | Subject | Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI |
| |
Hi Christoph,
On Sun, Jul 8, 2018 at 1:23 PM, Christoph Hellwig <hch@infradead.org> wrote: > On Thu, May 24, 2018 at 10:06:59AM -0700, Kees Cook wrote: >> On Thu, May 24, 2018 at 1:00 AM, Christoph Hellwig <hch@infradead.org> wrote: >> > On Wed, May 23, 2018 at 03:14:19PM -0600, Jens Axboe wrote: >> >> Ugh, so that would necessitate a change there too. As I said before, >> >> I don't really care where it lives. I know the SCSI folks seem bothered >> >> by moving it, but in reality, it's not like this stuff will likely ever >> >> really change. Of the two choices (select entire SCSI stack, or just move >> >> this little bit), I know what I would consider the saner option... >> > >> > Oh well. How about something like this respin of Kees' series? >> > >> > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/sense-cleanup >> >> Does the CONFIG_PCMCIA in drivers/scsi/Makefile now get exposed in >> weird config cases? >> >> Otherwise, yeah, looks good to me. Thanks! > > Btw, did you plan to resend the series with this and your changes > applied?
Yeah, I've gotten distracted. I'll try to get to it in the next few days.
Thanks for the reminder!
-Kees
-- Kees Cook Pixel Security
| |