Messages in this thread | | | Subject | Re: [PATCH v4 6/6] crypto: qcom: Add ACPI support | From | Jeffrey Hugo <> | Date | Mon, 9 Jul 2018 08:52:21 -0600 |
| |
On 7/9/2018 12:01 AM, Vinod wrote: > On 07-07-18, 13:05, Timur Tabi wrote: >> On 7/5/18 1:07 AM, Vinod wrote: >>> Yes we can add driver data in ACPI ID as well so code can be: >>> >>> if (!has_acpi_companion(&pdev->dev)) { >>> rng->clk = devm_clk_get(&pdev->dev, "core"); >>> if (IS_ERR(rng->clk)) >>> return PTR_ERR(rng->clk); >>> } >>> rng->skip_init = device_get_match_data(&pdev->dev); >>> >>> Looks much neater. >> >> Yeah, I like it. >> >>> I will wait for feedback on other patches before updating this. >> >> Jeff said it works, so I guess v5 will be good to go. > > Yes posting that right now. It would be great if you folks can test > again on ACPI systems > > Thanks > I might need a day, but I'll get to it.
-- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |