Messages in this thread | | | From | Rob Herring <> | Date | Mon, 9 Jul 2018 08:16:45 -0600 | Subject | Re: [PATCH 06/17] dt-bindings: display: sun4i-drm: Add R40 TV TCON description |
| |
On Fri, Jul 6, 2018 at 2:46 PM Jernej Škrabec <jernej.skrabec@siol.net> wrote: > > Dne petek, 06. julij 2018 ob 22:40:52 CEST je Rob Herring napisal(a): > > On Fri, Jul 06, 2018 at 07:51:02PM +0200, Jernej Skrabec wrote: > > > TCON description is expanded with R40 TV TCON compatible. It is a bit > > > special, because it is connected to TCON TOP instead directly to mixer > > > and it needs special handling. > > > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > > > --- > > > > > > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > Please add acks/reviews when posting new versions. > > This is not exactly the same version you give ack for, so I didn't include it.
Then you need to state what changed (in this patch) and why you didn't add the ack.
> I'm not sure where the line for that is. > > In contrast to previous version, it doesn't introduce additional clock.
Sounds trivial enough to keep the ack.
Rob
| |