Messages in this thread | | | Date | Mon, 9 Jul 2018 12:14:37 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v3 3/5] ASoC: qcom: add sdm845 sound card support |
| |
On Fri, Jul 06, 2018 at 03:13:13PM +0530, Rohit kumar wrote:
> @@ -0,0 +1,390 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2018, The Linux Foundation. All rights reserved. > + */
Please make the entire comment block a C++ comment, it makes it look more intentional.
> +static const struct component_master_ops sdm845_ops = { > + .bind = sdm845_bind, > + .unbind = sdm845_unbind, > +};
Why is this using the component stuff rather than the normal support for finding the components of audio cards? [unhandled content-type:application/pgp-signature] | |