lkml.org 
[lkml]   [2018]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 03/18] fs_context: fix detecting full log buffer
    Date
    Eric Biggers <ebiggers3@gmail.com> wrote:

    > When 'head' and 'tail' wrap around, 'log->head - log->tail' will be
    > something like '4 - 252 = -248', and comparing that directly to the
    > array size is wrong. Fix by casting to 'u8'.

    I think a better fix is to use CIRC_CNT() or CIRC_SPACE().

    David

    \
     
     \ /
      Last update: 2018-07-09 11:33    [W:2.335 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site