Messages in this thread | | | Date | Sun, 8 Jul 2018 13:44:30 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH 1/2] mtd: rawnand: docg4: fix NULL deref while probing |
| |
Hi Sergey,
Sergey Larin <cerg2010cerg2010@mail.ru> wrote on Sun, 8 Jul 2018 14:29:23 +0300:
> nand_scan_tail() invokes nand_chip->scan_bbt() at the end, which is not set > by the driver. Use the default nand_default_bbt() function to avoid NULL > dereferncing.
dereferencing
> > Signed-off-by: Sergey Larin <cerg2010cerg2010@mail.ru>
Maybe a Fixes/stable tags would be appropriate here if this is a real runtime error?
> --- > drivers/mtd/nand/raw/docg4.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/nand/raw/docg4.c b/drivers/mtd/nand/raw/docg4.c > index bb96cb33cd6b..bbed8ea7858c 100644 > --- a/drivers/mtd/nand/raw/docg4.c > +++ b/drivers/mtd/nand/raw/docg4.c > @@ -1269,6 +1269,7 @@ static void __init init_mtd_structs(struct mtd_info *mtd) > nand->read_buf = docg4_read_buf; > nand->write_buf = docg4_write_buf16; > nand->erase = docg4_erase_block; > + nand->scan_bbt = nand_default_bbt; > nand->set_features = nand_get_set_features_notsupp; > nand->get_features = nand_get_set_features_notsupp; > nand->ecc.read_page = docg4_read_page;
-- Miquel Raynal, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
| |