Messages in this thread | | | Date | Sat, 7 Jul 2018 10:19:50 +0200 | From | Lukas Wunner <> | Subject | Re: [PATCH] thunderbolt: fix small typo in variable name |
| |
On Tue, Jun 26, 2018 at 04:34:20PM -0700, nathan.d.ciobanu@linux.intel.com wrot> Fixes small variable name typo and the associated > checkpatch spelling warning > > Signed-off-by: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com> > --- > drivers/thunderbolt/tb_regs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thunderbolt/tb_regs.h b/drivers/thunderbolt/tb_regs.h > index 5d94142afda6..693b0353c3fe 100644 > --- a/drivers/thunderbolt/tb_regs.h > +++ b/drivers/thunderbolt/tb_regs.h > @@ -202,7 +202,7 @@ struct tb_regs_port_header { > /* DWORD 5 */ > u32 max_in_hop_id:11; > u32 max_out_hop_id:11; > - u32 __unkown4:10; > + u32 __unknown4:10; > /* DWORD 6 */ > u32 __unknown5; > /* DWORD 7 */
This is not an improvement. The bitfield is marked unknown because its meaning hasn't been reverse-engineered yet. But you work for Intel, presumably you don't have to reverse-engineer the bitfield's meaning because you know it or can find out about it.
So please submit a patch that changes the name to the bitfield's actual meaning.
Thanks,
Lukas
| |