lkml.org 
[lkml]   [2018]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] mtd: nxp-spifi: release flash_np in nxp_spifi_probe()
On Wed,  9 May 2018 18:11:20 +0300
Alexey Khoroshilov <khoroshilov@ispras.ru> wrote:

> nxp_spifi_probe() increments refcnt of SPI flash device node by
> of_get_next_available_child() and leaves it undecremented on both
> successful and error paths.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Applied after fixing the subject prefix.

> ---
> v3: Move of_node_put() before return value check as Boris Brezillon suggested.
>
> drivers/mtd/spi-nor/nxp-spifi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/nxp-spifi.c b/drivers/mtd/spi-nor/nxp-spifi.c
> index 15374216d4d9..0c9094ec5966 100644
> --- a/drivers/mtd/spi-nor/nxp-spifi.c
> +++ b/drivers/mtd/spi-nor/nxp-spifi.c
> @@ -436,6 +436,7 @@ static int nxp_spifi_probe(struct platform_device *pdev)
> }
>
> ret = nxp_spifi_setup_flash(spifi, flash_np);
> + of_node_put(flash_np);
> if (ret) {
> dev_err(&pdev->dev, "unable to setup flash chip\n");
> goto dis_clks;

\
 
 \ /
  Last update: 2018-07-07 08:59    [W:0.039 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site