lkml.org 
[lkml]   [2018]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: dac: remove redundant variable 'shift'
On Mon, 2 Jul 2018 12:43:20 +0200
Sean Nyekjær <sean.nyekjaer@prevas.dk> wrote:

> On 2018-07-02 12:24, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Variable shift is being assigned but is never used hence it is
> > redundant and can be removed.
> >
> > Cleans up two clang warnings:
> > warning: variable ‘shift’ set but not used [-Wunused-but-set-variable]
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
>
> Good catch :-)
>
> BR
> /Sean
Hi Colin,

As ever, thanks for the patch!

If you wouldn't mind putting the name of the driver in question in patches
like these that would be great. There are enough drivers, that I doubt
anyone (other than me) looks at all patches for DACs. They only look at
the particular parts they actually have on boards ;)

Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Thanks,

Jonathan


\
 
 \ /
  Last update: 2018-07-07 18:46    [W:0.033 / U:1.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site