Messages in this thread | | | From | Krzysztof Kozlowski <> | Date | Sat, 7 Jul 2018 17:34:08 +0200 | Subject | Re: [PATCH] ARM: dts: exynos: add max77693 irq configuration for midas |
| |
On 7 July 2018 at 16:45, Simon Shields <simon@lineageos.org> wrote: > Currently, we assume that the bootloader has correctly configured > the interrupt pin for max77693. This might not actually be the case - > so it's better to configure it explicitly. > > Signed-off-by: Simon Shields <simon@lineageos.org> > --- > arch/arm/boot/dts/exynos4412-midas.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi > index f35176a35a15..30760bf2eb71 100644 > --- a/arch/arm/boot/dts/exynos4412-midas.dtsi > +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi > @@ -156,6 +156,8 @@ > compatible = "maxim,max77693"; > interrupt-parent = <&gpx1>; > interrupts = <5 IRQ_TYPE_EDGE_FALLING>; > + pinctrl-names = "default"; > + pinctrl-0 = <&max77693_irq>; > reg = <0x66>; > > regulators { > @@ -1117,6 +1119,13 @@ > samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>; > }; > > + max77693_irq: max77693-irq { > + samsung,pins = "gpx1-5"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>; > + }; > +
Please put it before hdmi-hpd (gpx3-7). What about the interrupt for max77693 fuel gauge? Maybe another patch for it as well?
Best regards, Krzysztof
> sleep1: sleep-states { > PIN_SLP(gpk0-0, PREV, NONE); > PIN_SLP(gpk0-1, PREV, NONE); > -- > 2.18.0 >
| |