Messages in this thread | | | From | "Michael Kelley (EOSG)" <> | Subject | RE: [PATCH 1/1] X86/Hyper-V:: Fix the circular dependency in IPI enlightenment. | Date | Fri, 6 Jul 2018 16:12:16 +0000 |
| |
> -----Original Message----- > From: Thomas Gleixner <tglx@linutronix.de> > Sent: Friday, July 6, 2018 3:42 AM > To: KY Srinivasan <kys@microsoft.com> > Cc: Ingo Molnar <mingo@kernel.org>; x86@kernel.org; gregkh@linuxfoundation.org; linux- > kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; > jasowang@redhat.com; hpa@zytor.com; Stephen Hemminger <sthemmin@microsoft.com>; > Michael Kelley (EOSG) <Michael.H.Kelley@microsoft.com>; vkuznets@redhat.com > Subject: RE: [PATCH 1/1] X86/Hyper-V:: Fix the circular dependency in IPI enlightenment. > > On Fri, 6 Jul 2018, Thomas Gleixner wrote: > > On Fri, 6 Jul 2018, KY Srinivasan wrote: > > > > > > > > The problem is that the wreckage is in Linus tree and needs to be fixed > > > > there, i.e. via x86/urgent. > > > > > > > > Now we have the new bits queued in x86/hyperv already which collide. So > > > > we > > > > need to merge x86/urgent into x86/hyperv after applying the fix and mop up > > > > the merge wreckage in x86/hyperv. > > > > > > > > I'll have a look tomorrow morning unless you beat me to it. > > > > > > I can rebase this patch against the latest tip and resend (tomorrow). > > > > That doesn't help as we need to push the original fix to Linus ... > > Applied it to x86/urgent and fixed up the '-1' sloppy hack as pointed out > by Vitaly and merged x86/urgent into x86/hyperv. > > Please check both branches for correctness.
Changes look good to me. Some pre-existing signed/unsigned type sloppiness is still there in that hv_cpu_number_to_vp_number() should be 'u32' instead of 'int', along with related local variables, but that's probably best to fix in linux-next on top of Vitaly's other changes. This code will work.
Michael
> > Thanks, > > tglx
| |