lkml.org 
[lkml]   [2018]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] wireless: mark expected switch fall-throughs
From
Date
Hi Gustavo,

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.

You dropped the remark saying you didn't review them, but did you?

> case NL80211_CHAN_WIDTH_20:
> if (!ht_cap->ht_supported)
> return false;
> + /* else: fall through */

What's the point in else:?

We also don't necessarily write

if (!...)
return false;
else
do_something();

but rather

if (!...)
return false;
do_something().

I think I'd prefer without the "else:"

johannes

\
 
 \ /
  Last update: 2018-07-06 14:30    [W:0.050 / U:1.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site