Messages in this thread | | | Date | Fri, 6 Jul 2018 07:09:13 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v10 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC |
| |
On Thu, 05 Jul 2018, Enric Balletbo Serra wrote:
> Missatge de Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> del > dia dj., 5 de jul. 2018 a les 16:32: > > > > ROHM BD71837 PMIC MFD driver providing interrupts and support > > for three subsystems: > > - clk > > - Regulators > > - input/power-key > > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > > --- > > drivers/mfd/Kconfig | 13 ++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/rohm-bd718x7.c | 198 +++++++++++++++++++++++ > > include/linux/mfd/rohm-bd718x7.h | 333 +++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 545 insertions(+) > > create mode 100644 drivers/mfd/rohm-bd718x7.c > > create mode 100644 include/linux/mfd/rohm-bd718x7.h
[snipping ~550 lines of code]
> The main changes I requested are done so I think you can maintain my > reviewed-by. > > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks for your review, it's much appreciated.
In future would you mind trimming your mails back to only include relevant sections please? Going through ~550 lines of code page by page trying to find your response was a little painful. TIA.
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |