| From | Bart Van Assche <> | Subject | Re: [PATCH 2/4] scsi: bfa: remove ScsiResult macro | Date | Thu, 5 Jul 2018 17:00:10 +0000 |
| |
On Thu, 2018-07-05 at 13:01 +0200, Johannes Thumshirn wrote: > - cmnd->result = ScsiResult(DID_OK, SCSI_STATUS_GOOD); > + cmnd->result = DID_OK << 16 | SCSI_STATUS_GOOD;
Please consider to remove the SCSI_STATUS_GOOD constant since it is non-standard and since it used by the bfa driver only. Additionally, since SCSI_STATUS_GOOD == 0, please leave out "| SCSI_STATUS_GOOD".
Thanks,
Bart.
|