lkml.org 
[lkml]   [2018]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/4] scsi: bfa: remove ScsiResult macro
Date
On Thu, 2018-07-05 at 13:01 +0200, Johannes Thumshirn wrote:
> - cmnd->result = ScsiResult(DID_OK, SCSI_STATUS_GOOD);
> + cmnd->result = DID_OK << 16 | SCSI_STATUS_GOOD;

Please consider to remove the SCSI_STATUS_GOOD constant since it is
non-standard and since it used by the bfa driver only. Additionally, since
SCSI_STATUS_GOOD == 0, please leave out "| SCSI_STATUS_GOOD".

Thanks,

Bart.



\
 
 \ /
  Last update: 2018-07-05 19:00    [W:0.135 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site