Messages in this thread | | | Date | Wed, 4 Jul 2018 22:55:06 -0700 | From | Tony Lindgren <> | Subject | Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset |
| |
* Faiz Abbas <faiz_abbas@ti.com> [180704 13:37]: > After taking a second look at this thread, I don't see anything big to > be modified. > > We both agree that "reset status bit in sysconfig register" is the quirk > case which can be added once such an IP is discovered in ti-sysc.
Yes agreed.
> All I need to change is SYSC_OMAP4_SOFTRESET to SYSC_SOFT_RESET_SHIFT_0 > for better readability and rebase it to the latest mainline.
Let's not change SYSC_OMAP4_SOFTRESET as only the ti-sysc driver needs to know that and it can be set based on the compatible.
How about replace ddata->cfg.quirks & SYSC_QUIRK_RESET_STATUS test with just ddata->cfg.syss_mask test in your sysc_reset()?
We still need to set SYSC_QUIRK_RESET_STATUS too for pdata callbacks.
Regards,
Tony
| |