lkml.org 
[lkml]   [2018]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [External] Re: [PATCH 3/3] fs/dax: Assigning NULL to gfn of dax_direct_access if useless
Date
From: Dan Williams [mailto:dan.j.williams@intel.com]
Sent: Wednesday, July 04, 2018 10:42 PM
>
> On Wed, Jul 4, 2018 at 7:37 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> > On Wed, Jul 4, 2018 at 6:07 AM, Huaisheng Ye <yehs2007@zoho.com> wrote:
> >> ---- On Wed, 04 Jul 2018 19:30:12 +0800 Jan Kara <jack@suse.cz> wrote ----
> >> > On Wed 04-07-18 14:40:58, Huaisheng Ye wrote:
> >> > > From: Huaisheng Ye <yehs1@lenovo.com>
> >> > >
> >> > > Some functions within fs/dax don't need to get gfn from direct_access.
> >> > > Assigning NULL to gfn of dax_direct_access is more intuitive and simple
> >> > > than offering a useless local variable.
> >> > >
> >> > > Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
> >> >
> >> > I like this. You can add:
> >> >
> >> > Reviewed-by: Jan Kara <jack@suse.cz>
> >> >
> >> > for the series.
> >> >
> >> > Honza
> >> >
> >> I am so happy you like them, thank you very much.
> >
> > Yes, I like this too. In fact I have a similar patch in my tree
> > already that I have been preparing to send out. I am using it to delay
> > when we need to have the 'struct page' memmap for dax initialized.
> > Attached is the full patch, but the series is still a work in
> > progress.
>
> Btw, I'll drop my version and apply your series since you got it
> posted first and it can stand alone as its own cleanup.

Hi Dan,

I will resend the series later, and thanks for your help.

Cheers,
Huaisheng Ye
\
 
 \ /
  Last update: 2018-07-04 17:37    [W:0.066 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site