Messages in this thread | | | Subject | Re: [PATCH v3 10/20] kvm: arm64: Dynamic configuration of VTTBR mask | From | Suzuki K Poulose <> | Date | Wed, 4 Jul 2018 09:29:06 +0100 |
| |
On 07/04/2018 09:24 AM, Auger Eric wrote: >>>> + * >>>> + * We have a magic formula for the Magic_N below. >>>> + * >>>> + * Magic_N(PAGE_SIZE, Entry_Level) = 64 - ((PAGE_SHIFT - 3) * >>>> Number of levels) >> >> [0] ^^^ >> >> >> >>>> + * >>>> + * where number of levels = (4 - Entry_Level). >> >> ^^^ Doesn't this help make it clear ? Using the expansion makes it a bit >> more >> unreadable below. > > I just wanted to mention the tables you refer (D4-23 and D4-25) give > Magic_N for a larger scope as they deal with any lookup level while we > only care about the entry level for BADDR. So I was a little bit > confused when reading the explanation but that's not a big deal.
Ah, ok. I will try to clarify it.
Cheers Suzuki
| |