Messages in this thread | | | Subject | Re: [PATCH v2 7/7] net: phy: Add pm support to Broadcom iProc mdio mux driver | From | Arun Parameswaran <> | Date | Tue, 31 Jul 2018 10:51:48 -0700 |
| |
Hi Florian,
On 18-07-30 03:53 PM, Florian Fainelli wrote: > On 07/27/2018 02:23 PM, Arun Parameswaran wrote: >> Add support for suspend and resume to the Broadcom iProc mdio >> mux driver. >> >> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com> >> --- >> drivers/net/phy/mdio-mux-bcm-iproc.c | 28 ++++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/drivers/net/phy/mdio-mux-bcm-iproc.c b/drivers/net/phy/mdio-mux-bcm-iproc.c >> index 51d1003..d89dce0 100644 >> --- a/drivers/net/phy/mdio-mux-bcm-iproc.c >> +++ b/drivers/net/phy/mdio-mux-bcm-iproc.c >> @@ -290,6 +290,33 @@ static int mdio_mux_iproc_remove(struct platform_device *pdev) >> return 0; >> } >> >> +#ifdef CONFIG_PM_SLEEP >> +static int mdio_mux_iproc_suspend(struct device *dev) >> +{ >> + struct iproc_mdiomux_desc *md = dev_get_drvdata(dev); >> + >> + if (md->core_clk) >> + clk_disable_unprepare(md->core_clk); > > Since you are assigning md->core_clk to NULL in case clk_get() returned > an error, checking for md->core_clk is not necessary since the Linux > common clock framework perform that NULL check already. > Will remove the check.
I am working on Andrew's comments (which will add one more patch to the series). I will send the whole patchset again, with reviewed-by tags (From Florian and Andrew on the ones that apply).
Thanks Arun
| |